From 853b1d81aceea1d1ec09741ef6489e912163652d Mon Sep 17 00:00:00 2001 From: Amit Kumar Nandi <11887616+aamitn@users.noreply.github.com> Date: Fri, 1 Mar 2024 03:56:26 +0530 Subject: [PATCH] fixups --- pom.xml | 2 +- src/main/java/org/nmpl/App.java | 5 ++++- src/main/java/org/nmpl/DbExporter.java | 4 ++-- src/main/java/org/nmpl/exporters/TestExporter.java | 9 +++++++++ src/test/java/org/nmpl/AppTest.java | 2 +- src/test/java/org/nmpl/ExporterFactoryTest.java | 2 -- 6 files changed, 17 insertions(+), 7 deletions(-) diff --git a/pom.xml b/pom.xml index 13eddd8..aa4d4f7 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ exec-maven-plugin 3.1.1 - org.nmpl.v0.App + org.nmpl.App diff --git a/src/main/java/org/nmpl/App.java b/src/main/java/org/nmpl/App.java index 3d9cdb3..1ea074d 100644 --- a/src/main/java/org/nmpl/App.java +++ b/src/main/java/org/nmpl/App.java @@ -5,10 +5,13 @@ import java.sql.SQLException; public class App { public static void main(String[] args) { + final String dbName = "shortener"; + final String username = "root"; + final String pasword = "1234qwer"; SwingUtilities.invokeLater(() -> { DbExporter manager; try { - manager = new DbExporter(); + manager = new DbExporter(dbName,username,pasword); } catch (SQLException e) { throw new RuntimeException(e); diff --git a/src/main/java/org/nmpl/DbExporter.java b/src/main/java/org/nmpl/DbExporter.java index 4cd1820..ca75d44 100644 --- a/src/main/java/org/nmpl/DbExporter.java +++ b/src/main/java/org/nmpl/DbExporter.java @@ -14,8 +14,8 @@ public class DbExporter extends JFrame { private final DefaultListModel tableListModel; private final Connection connection; - public DbExporter() throws SQLException { - connection = DriverManager.getConnection("jdbc:mysql://localhost:3306/bankdb", "root", "1234qwer"); + public DbExporter(String dbName,String username,String pasword) throws SQLException { + connection = DriverManager.getConnection("jdbc:mysql://localhost:3306/"+dbName, username, pasword); setTitle("Database Manager"); setSize(400, 400); setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); diff --git a/src/main/java/org/nmpl/exporters/TestExporter.java b/src/main/java/org/nmpl/exporters/TestExporter.java index 2f54ccd..23f4b1d 100644 --- a/src/main/java/org/nmpl/exporters/TestExporter.java +++ b/src/main/java/org/nmpl/exporters/TestExporter.java @@ -1,10 +1,19 @@ package org.nmpl.exporters; + + import org.nmpl.ExportType; import org.nmpl.Exportable; +import java.sql.Connection; @ExportType("TEST") public class TestExporter implements Exportable { + private final Connection connection; + + public TestExporter(Connection connection) { + this.connection = connection; + } + @Override public void export(String tableName, String fileName) { try { diff --git a/src/test/java/org/nmpl/AppTest.java b/src/test/java/org/nmpl/AppTest.java index 16b0d99..9c7ad32 100644 --- a/src/test/java/org/nmpl/AppTest.java +++ b/src/test/java/org/nmpl/AppTest.java @@ -2,7 +2,7 @@ package org.nmpl; import org.fest.swing.fixture.FrameFixture; import org.junit.jupiter.api.Test; -import org.nmpl.v0.DbExporter; +import org.nmpl.DbExporter; import javax.swing.*; import java.sql.SQLException; diff --git a/src/test/java/org/nmpl/ExporterFactoryTest.java b/src/test/java/org/nmpl/ExporterFactoryTest.java index adbe158..6dae40b 100644 --- a/src/test/java/org/nmpl/ExporterFactoryTest.java +++ b/src/test/java/org/nmpl/ExporterFactoryTest.java @@ -5,8 +5,6 @@ import org.junit.jupiter.api.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.nmpl.exporters.XMLExporter; -import org.nmpl.v0.Exportable; -import org.nmpl.v0.ExporterFactory; import java.sql.Connection; import java.util.List;